Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the web-api response types with the latest data source #1403

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Dec 15, 2021

Summary

This pull request re-generates all the web-api response types. Due to an improvement (=more robust way to merge new properties to existing data source) on the data source generation code in the Java SDK, some of the property orders in the data were changed. That being said, there is no addition/deletion of properties.

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` labels Dec 15, 2021
@seratch seratch added this to the web-api@6.6.0 milestone Dec 15, 2021
@seratch seratch self-assigned this Dec 15, 2021
@srajiang srajiang self-requested a review December 15, 2021 17:30
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seratch seratch merged commit 39977dc into slackapi:main Dec 15, 2021
@seratch seratch deleted the web-api-types-2021-12-15 branch December 15, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants